Skip to content

Update repositories.txt #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2023
Merged

Update repositories.txt #3660

merged 1 commit into from
Nov 28, 2023

Conversation

adrian2793
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

A problem was found with your submission https://github.com/Arduino-Library-Collection/DC-Motor-Engine-Control

❌ ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @adrian2793
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@adrian2793
Copy link
Contributor Author

@ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions GitHub Actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/Arduino-Library-Collection/DC-Motor-Engine-Control:

Linting library in DC-Motor-Engine-Control
INFO: No header file found matching library name (DC_Motor_Engine_Control.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value DC Motor Engine Control is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
WARNING: library.properties name DC Motor Engine Control contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: No readme found. Please document your library.                                                                                
         See:                                                                                                                          
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes
         (Rule LD001)                                                                                                                  
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

@github-actions github-actions bot merged commit 9fe3b7f into arduino:main Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/Arduino-Library-Collection/DC-Motor-Engine-Control/

github-actions bot pushed a commit that referenced this pull request Nov 28, 2023
@ArduinoBot
Add submission # 3660
ebdcedc 
#3660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
topic: submission Add library to the list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adrian2793